Changeset 521

Timestamp:

08/16/08 08:30:32 (5 months ago)

Author:

rgl

Message:

Bugfix: we are resuing the same XHR instance; for this to work in IE we must set the onreadystatechange handler after we call open.

Files:

• trunk/daemon/orbited/static/Orbited.js (modified) (2 diffs)

trunk/daemon/orbited/static/Orbited.js

@@ -637 +637 @@
         var numSent = sendQueue.length
         sessionUrl.setQsParameter('ack', lastPacketId)
-//        xhr = createXHR();
+        var tdata = encodePackets(sendQueue)
+;;;     self.logger.debug('post', retries, tdata);
+        if (Orbited.settings.enableFFPrivleges) {
+            try { 
+                netscape.security.PrivilegeManager.enablePrivilege('UniversalBrowserRead'); 
+            } catch (ex) { } 
+        }        
+        xhr.open('POST', sessionUrl.render(), true)
+        // NB: its awkard, but for reusing the XHR object in IE (7 at least),
+        //     we can only reset the onreadystatechange *after* we call open;
+        //     if we don't do this, the XHR will stop sending data.
+        // See "Reusing XMLHttpRequest Object in IE"
+        //     at http://keelypavan.blogspot.com/2006/03/reusing-xmlhttprequest-object-in-ie.html
         xhr.onreadystatechange = function() {
             switch(xhr.readyState) {
-                
                 case 4:
                     if (xhr.status == 200) {
@@ -658 +669 @@
             }
         }
-        var tdata = encodePackets(sendQueue)
-;;;     self.logger.debug('post', retries, tdata);
-        if (Orbited.settings.enableFFPrivleges) {
-            try { 
-                netscape.security.PrivilegeManager.enablePrivilege('UniversalBrowserRead'); 
-            } catch (ex) { } 
-        }        
-        xhr.open('POST', sessionUrl.render(), true)
         xhr.send(tdata)
-
     }